fix(validator): improve validateObject and validateValueForProperty methods#2130
Merged
Merged
Conversation
tux-eithel
changed the title
Member
|
Nice, I'm happy to merge this :) And sorry for the late reply! Can you take a look at that one failing test? |
Contributor
Author
|
Hi @brendt ! Done! |
Contributor
Author
|
Do you think is worth adding documentation for If the feature can be made public, I can open another PR, with documentation improvements. Let me know! |
Member
|
Definitely worth documenting! Feel free to send a followup PR |
Member
|
Thanks! Will tag in a second |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2131.
I added several assertions for the exception.
Let me know if they're okay, or should be moved in a specific test inside
tests/Integration/Validator.